Skip to content

[Benchmarks] Use GitProject for git operations #20207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 30, 2025
Merged

[Benchmarks] Use GitProject for git operations #20207

merged 2 commits into from
Sep 30, 2025

Conversation

PatKamin
Copy link
Contributor

Use GitProject for git operations instead of utility methods. Plus, remove directory path in suites' ctors as this path can be obtained from the options module.

@PatKamin PatKamin requested a review from a team as a code owner September 26, 2025 07:53
lukaszstolarczuk
lukaszstolarczuk requested changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the CI has failed

@PatKamin
Copy link
Contributor Author

the CI has failed

Thanks, fixed

lukaszstolarczuk
lukaszstolarczuk approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks good, thx

@lukaszstolarczuk
Copy link
Contributor

@intel/llvm-gatekeepers, please merge.

@steffenlarsen steffenlarsen merged commit d1abb0c into intel:sycl Sep 30, 2025
28 checks passed
@PatKamin PatKamin deleted the use-git-project branch September 30, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PatKamin @lukaszstolarczuk @steffenlarsen